Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: enable filter and cluster when client consumer provider directly #1181

Merged
merged 10 commits into from
May 15, 2021

Conversation

kzhan
Copy link
Contributor

@kzhan kzhan commented Apr 27, 2021

客户端直连模式下启用 filter 和 cluster处理

@@ -20,6 +20,7 @@ package config
import (
"context"
"fmt"
"github.com/apache/dubbo-go/protocol/protocolwrapper"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to the 3rd import block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it to the 3rd import block

ok

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #1181 (928206d) into 3.0 (968650f) will decrease coverage by 3.54%.
The diff coverage is 51.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1181      +/-   ##
==========================================
- Coverage   59.53%   55.99%   -3.55%     
==========================================
  Files         259      269      +10     
  Lines       12737    12839     +102     
==========================================
- Hits         7583     7189     -394     
- Misses       4199     4757     +558     
+ Partials      955      893      -62     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failback_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failfast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/failover_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failsafe_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/forking_cluster.go 100.00% <ø> (ø)
... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d385de5...928206d. Read the comment docs.

@AlexStocks AlexStocks force-pushed the feature/client_direct_call branch 2 times, most recently from dcfc5e3 to 31e9df8 Compare May 15, 2021 04:47
@AlexStocks AlexStocks changed the title Feature/client direct call Ftr: enable filter and cluster when client consumer provider directly May 15, 2021
@AlexStocks AlexStocks merged commit bda9a0b into apache:3.0 May 15, 2021
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants