Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:delete a service provider when using k8s hpa (3.0) #1157

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

jack15083
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #1141

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jack15083 jack15083 changed the title fix registery dir cache key issue Fix:delete a service provider when using k8s hpa (3.0) Apr 14, 2021
@codecov-io
Copy link

Codecov Report

Merging #1157 (a46ea43) into 3.0 (474ec0a) will decrease coverage by 1.35%.
The diff coverage is 61.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1157      +/-   ##
==========================================
- Coverage   59.21%   57.86%   -1.36%     
==========================================
  Files         269      252      -17     
  Lines       13181    12480     -701     
==========================================
- Hits         7805     7221     -584     
+ Misses       4408     4347      -61     
+ Partials      968      912      -56     
Impacted Files Coverage Δ
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <0.00%> (ø)
common/extension/cluster.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <0.00%> (ø)
common/extension/config_center_factory.go 0.00% <0.00%> (ø)
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/config_reader.go 0.00% <0.00%> (ø)
common/extension/configurator.go 0.00% <0.00%> (ø)
common/extension/filter.go 0.00% <0.00%> (ø)
common/extension/graceful_shutdown.go 0.00% <0.00%> (ø)
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec80b8...a46ea43. Read the comment docs.

@AlexStocks AlexStocks merged commit 0bd7945 into apache:3.0 Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants