Ftr: add pass through proxy factory #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceLiZhixin
changed the title
watermelo
reviewed
Mar 11, 2021
common/constant/key.go
Outdated
| @@ -50,7 +50,8 @@ const ( | |||
| PROTOCOL_KEY = "protocol" | |||
| PATH_SEPARATOR = "/" | |||
| //DUBBO_KEY = "dubbo" | |||
| SSL_ENABLED_KEY = "ssl-enabled" | |||
| SSL_ENABLED_KEY = "ssl-enabled" | |||
| ParameterTypeKey = "parameter-type-names" // ParameterType key used in dapr, to tranfer rsp param type | |||
There was a problem hiding this comment.
Maybe follow the codeSSL_ENABLED_KEY .
| var args [][]byte | ||
| if len(arguments) == 0 { | ||
| args = [][]byte{} | ||
| } else { |
There was a problem hiding this comment.
We can reduce a if-else branch by
if len(arguments) > 0 {
args = make([][]byte, 0, len(arguments))
for _, arg := range arguments {
if v, ok := arg.([]byte); ok {
args = append(args, v)
} else {
result.Err = perrors.New("the param type is not []byte")
return result
}
}
}| } | ||
| method := srv.Method()["Service"] | ||
|
|
||
| in := []reflect.Value{srv.Rcvr()} |
There was a problem hiding this comment.
Init with length in := make([]reflect.Value, 5).
| replyv := returnValues[0] | ||
| retErr = returnValues[1].Interface() | ||
|
|
||
| if retErr != nil { |
There was a problem hiding this comment.
Maybe more appropriate.
if retErr != nil {
result.SetError(retErr.(error))
return result
}
if replyv.IsValid() && (replyv.Kind() != reflect.Ptr || replyv.Kind() == reflect.Ptr && replyv.Elem().IsValid()) {
result.SetResult(replyv.Interface())
}
return result
registry/directory/directory.go
Outdated
| logger.Infof("selector add service url{%s}", event.Service) | ||
| // FIXME: routers are built in every address notification? | ||
| dir.configRouters() | ||
| if event.Service != nil { |
There was a problem hiding this comment.
if event != nil && event.Service != nil
LaurenceLiZhixin
changed the title
AlexStocks
reviewed
Mar 18, 2021
README.md
Outdated
| @@ -177,7 +177,7 @@ If you are willing to do some code contributions and document contributions to [ | |||
|
|
|||
| ## Community | |||
|
|
|||
| If u want to communicate with our community, pls scan the following [dubbobo Ding-Ding QR code](https://mmbiz.qpic.cn/mmbiz_jpg/yvBJb5IiafvnHVBdtia30dxA2hKotr9DEckWsZ7aOJcDWDaSVMGwLmYv8GRgIQtqb4C2svicp8nVkMmGy7yKC5tyA/640?wx_fmt=jpeg&tp=webp&wxfrom=5&wx_lazy=1&wx_co=1) or search our commnity DingDing group code 31363295. | |||
| If u want to communicate with our community, pls scan the following dubbobo Ding-Ding QR code or search our commnity DingDing group code 31363295. | |||
There was a problem hiding this comment.
"Ding-Ding " -> DingDing
AlexStocks
reviewed
Mar 18, 2021
|
|
||
| var args [][]byte | ||
| if len(arguments) > 0 { | ||
| args = make([][]byte, 0, len(arguments)) |
There was a problem hiding this comment.
the same comment as line 93: pls using gxbytes.AcquireBytes instead.
There was a problem hiding this comment.
gxbytes.AcquireBytes() is used to get specific make([]byte, 0, size), not to make [][]byte.
Codecov Report
@@ Coverage Diff @@
## 3.0 #1081 +/- ##
==========================================
- Coverage 60.03% 59.36% -0.68%
==========================================
Files 260 269 +9
Lines 12855 13441 +586
==========================================
+ Hits 7718 7979 +261
- Misses 4174 4475 +301
- Partials 963 987 +24
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Apr 3, 2021
wenxuwan
approved these changes
Apr 3, 2021
zhaoyunxing92
approved these changes
Apr 3, 2021
cityiron
pushed a commit
that referenced
this pull request
Apr 11, 2021
Ftr: add pass through proxy factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
add pass through factory
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
pass through proxy invoker can invoke user defined service, and pass through all data to user defined service. User can wirte logic to deal with raw invocation data.
It is very useful to dapr-dubbo support.
Does this PR introduce a user-facing change?: