Ftr: Triple Protocol Support #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1071 +/- ##
==========================================
- Coverage 60.03% 59.32% -0.72%
==========================================
Files 260 272 +12
Lines 12855 13350 +495
==========================================
+ Hits 7718 7920 +202
- Misses 4174 4453 +279
- Partials 963 977 +14
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Mar 7, 2021
AlexStocks
reviewed
Mar 7, 2021
go.mod
Outdated
| ) | ||
|
|
||
| replace ( | ||
| github.com/coreos/bbolt => go.etcd.io/bbolt v1.3.4 | ||
| github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.0 | ||
| github.com/shirou/gopsutil => github.com/shirou/gopsutil v0.0.0-20181107111621-48177ef5f880 | ||
| go.etcd.io/bbolt v1.3.4 => github.com/coreos/bbolt v1.3.3 |
There was a problem hiding this comment.
go.etcd.io/bbolt v1.3.4 => github.com/coreos/bbolt v1.3.4
AlexStocks
reviewed
Mar 7, 2021
AlexStocks
reviewed
Mar 7, 2021
| protocol.BaseInvoker | ||
| // the net layer client, it is focus on network communication. | ||
| client *dubbo3.TripleClient | ||
| quitOnce sync.Once |
There was a problem hiding this comment.
quitOnce for which object?
There was a problem hiding this comment.
fixed, for quit dubbo3 invoker.
AlexStocks
reviewed
Mar 7, 2021
wenxuwan
reviewed
Mar 7, 2021
protocol/dubbo3/dubbo3_invoker.go
Outdated
| dubbo3 "github.com/dubbogo/triple/pkg/triple" | ||
| ) | ||
|
|
||
| // DubboInvoker is implement of protocol.Invoker. A dubboInvoker refer to one service and ip. |
There was a problem hiding this comment.
Please refact implementation follow
wenxuwan
reviewed
Mar 7, 2021
protocol/dubbo3/dubbo3_protocol.go
Outdated
| "github.com/apache/dubbo-go/common/logger" | ||
| "github.com/apache/dubbo-go/config" | ||
| "github.com/apache/dubbo-go/protocol" | ||
| dubbo3 "github.com/dubbogo/triple/pkg/triple" |
There was a problem hiding this comment.
move it up to the 2rd import block.
wenxuwan
reviewed
Mar 7, 2021
flycash
reviewed
Mar 7, 2021
AlexStocks
reviewed
Mar 14, 2021
protocol/dubbo3/dubbo3_protocol.go
Outdated
| @@ -18,6 +18,7 @@ package dubbo3 | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| tripleCommon "github.com/dubbogo/triple/pkg/common" | |||
AlexStocks
reviewed
Mar 18, 2021
protocol/dubbo3/dubbo3_protocol.go
Outdated
| dp.serverLock.Lock() | ||
| defer dp.serverLock.Unlock() | ||
| // Stop all server | ||
| keyList := make([]string, 16) |
There was a problem hiding this comment.
move this line out of lock, pls.
wenxuwan
reviewed
Mar 18, 2021
config/config_loader.go
Outdated
| @@ -201,13 +201,17 @@ func loadProviderConfig() { | |||
| checkRegistries(providerConfig.Registries, providerConfig.Registry) | |||
|
|
|||
| for key, svs := range providerConfig.Services { | |||
| if key == "GrpcGreeterImpl2" { | |||
| fmt.Println("here") | |||
There was a problem hiding this comment.
the prints may be for your debug ??
AlexStocks
approved these changes
Apr 3, 2021
wenxuwan
approved these changes
Apr 3, 2021
ztelur
approved these changes
Apr 3, 2021
cityiron
pushed a commit
that referenced
this pull request
Apr 11, 2021
Ftr: Triple Protocol Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add Triple Protocol Support
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: