Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client couldn't correctly enable otel tracing when use new API #2586

Closed
ev1lQuark opened this issue Jan 24, 2024 · 0 comments · Fixed by #2587
Closed

Client couldn't correctly enable otel tracing when use new API #2586

ev1lQuark opened this issue Jan 24, 2024 · 0 comments · Fixed by #2587

Comments

@ev1lQuark
Copy link
Contributor

Environment

  • Server: Dubbo-go, v3.1.1-0.20240111064552-d21e6995a3c7
  • Client: Dubbo-go, v3.1.1-0.20240111064552-d21e6995a3c7
  • Protocol: Triple

Issue description

In client/client.go, Client.dial method starts use refOpts without cliOpts to carry out subsequent startup process. So in client/action.go, ReferenceOptions.getURLMap method couldn't correctly enable otel tracing.

image
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: client metrics and tracing can't enable ev1lQuark/dubbo-go
1 participant
@ev1lQuark