Merge pull request #266 from imxyb/bugfix/return-error

should return error when `NewURL` failed.
apache · Nov 27, 2019 · 78e7ed0 · 78e7ed0
2 parents d77b772 + e4561b6
commit 78e7ed0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/config_center/parser/configuration_parser.go b/config_center/parser/configuration_parser.go
@@ -134,14 +134,14 @@ func serviceItemToUrls(item ConfigItem, config ConfiguratorConfig) ([]*common.UR
 				newUrlStr = newUrlStr + v
 				url, err := common.NewURL(context.Background(), newUrlStr)
 				if err != nil {
-					perrors.WithStack(err)
+					return nil, perrors.WithStack(err)
 				}
 				urls = append(urls, &url)
 			}
 		} else {
 			url, err := common.NewURL(context.Background(), urlStr)
 			if err != nil {
-				perrors.WithStack(err)
+				return nil, perrors.WithStack(err)
 			}
 			urls = append(urls, &url)
 		}