Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Nullable annotations to SqlQuery #17398

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add missing @Nullable annotations to SqlQuery #17398

merged 2 commits into from
Oct 23, 2024

Conversation

abhishekrb19
Copy link
Contributor

@abhishekrb19 abhishekrb19 commented Oct 22, 2024 •
edited
Loading

Add missing @Nullable annotations to the SqlQuery constructor.

It will be better to use a builder pattern and add SqlQueryBuilder since we have a few booleans and some of the parameters are optional.

@abhishekrb19 abhishekrb19 merged commit 43b325b into apache:master Oct 23, 2024
87 of 90 checks passed
@abhishekrb19 abhishekrb19 deleted the missing_sql_query_annotations branch October 23, 2024 03:35
@abhishekrb19
Copy link
Contributor Author

CI failures are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Querying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekrb19 @clintropolis