Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SqlTaskStatus and SqlTaskStausTest to sql module #17380

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Move SqlTaskStatus and SqlTaskStausTest to sql module #17380

merged 1 commit into from
Oct 18, 2024

Conversation

abhishekrb19
Copy link
Contributor

@abhishekrb19 abhishekrb19 commented Oct 18, 2024 •
edited
Loading

  • This is a non-functional change that moves SqlTaskStatus and its unit test SqlTaskStatusTest from the msq module to the sql module to help class reuse in other places.
  • This refactor is extracted from 17353 to facilitate easier review.
  • Fix a minor spacing issue in the TaskStartTimeoutFault error message.

This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

@abhishekrb19
Move SqlTaskStatus and SqlTaskStausTest from msq module to sql module.
5721c2f 
This is required for the scheduled batch supervisor.
@github-actions github-actions bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 18, 2024
@zachjsh zachjsh self-requested a review October 18, 2024 19:55
@abhishekrb19 abhishekrb19 merged commit 9a16d4e into apache:master Oct 18, 2024
88 of 90 checks passed
@abhishekrb19 abhishekrb19 deleted the move_sql_task_status branch October 18, 2024 21:39
@abhishekrb19
Copy link
Contributor Author

abhishekrb19 commented Oct 18, 2024 •
edited
Loading

The failing ITs are unrelated to this patch.

Edit: succeeded on a retry; flaky ITs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachjsh zachjsh zachjsh approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekrb19 @zachjsh