Fixes an issue with AppendableMemory that can cause MSQ jobs to fail #17369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with the AppendableMemory where it fails the allocation even though there is enough space to complete it.
There are 2 components to the allocation -
availableToReserve
which returns the max allocation that can be requested. It returns the max of the available memory in the allocator and the free space in the last allocated blockreserveAdditional
makes the allocation and reserves the data(2) fails if the additionally reserved memory can be satisfied with the last allocated block but not by the allocator. Check the added test case for a better description of how this bug can arise.
Key changed/added classes in this PR
MyFoo
OurBar
TheirBaz
This PR has: