Skip to content

DRILL-8370: Upgrade splunk-sdk-java to 1.9.3 #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

jnturton
Copy link
Contributor

DRILL-8370: Upgrade splunk-sdk-java to 1.9.3

Description

Changes in splunk-sdk-java since 1.9.1.

Minor Changes

  • Re-fetch logic for instancetype and version fields if not set within Service instance to avoid NPE (GitHub PR #202)
  • Check for local IP as alternative to localhost within HostnameVerifier, addressing issue with certain local workflows
  • Added null check for child to handle error when no value is passed for a parameter in modular-inputs (Ref issue #198 & GitHub PR #199)

New Features and APIs

  • Added feature that allows to update ACL properties of an entity (GitHub PR #196)

Also removes the execution order dependence in the Splunk unit tests created by their expecting a certain number of records in the _audit index. I believe this order dependence is behind recent, apparently random CI run failures in the Splunk unit tests.

Documentation

N/A

Testing

Splunk unit tests.

@jnturton jnturton added dependencies ci CI backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there labels Dec 12, 2022
@jnturton jnturton requested a review from cgivre December 12, 2022 13:12
@jnturton jnturton self-assigned this Dec 12, 2022
Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 Pending CI.

@jnturton
Copy link
Contributor Author

The latest commit adds a patch for Splunk's broken validateCertificates toggle by @cgivre.

@cgivre
Copy link
Contributor

cgivre commented Dec 12, 2022

Just noting here for future reference, but here is the issue on Splunk's SDK that references the SSL issue:
splunk/splunk-sdk-java#204

}
}
};
context.init(null, trustAll, null);

Check failure

Code scanning / CodeQL

`TrustManager` that accepts all certificates

This uses [TrustManager](1), which is defined in [SplunkConnection$](2) and trusts any certificate.
@jnturton
Copy link
Contributor Author

@cgivre okay the last commit may have gotten rid of those sporadic CI failures 🤞.

@jnturton jnturton merged commit 536a246 into apache:master Dec 13, 2022
@jnturton jnturton removed the backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants