Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] (nereids)implement alterRoleCommand in nereids #43238

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Nov 5, 2024

What problem does this PR solve?

Issue Number: close #42799

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • [*] Regression test // done
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 5, 2024

run buildall

@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 5, 2024

run buildall

@Vallishp Vallishp force-pushed the nereids_alter_role branch 2 times, most recently from 7c716cc to 6c1fc9b Compare November 9, 2024 05:12
@Vallishp
Copy link
Contributor Author

Vallishp commented Nov 9, 2024

run buildall

@starocean999
Copy link
Contributor

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

starocean999
starocean999 previously approved these changes Nov 13, 2024
Copy link
Contributor

@starocean999 starocean999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@Vallishp
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit 7ef9e6e into apache:master Nov 14, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement alterRoleCommand in nereids
4 participants