Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[BUG] Using attachement strategy of brpc to send packet with big size." #4267

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Revert "[BUG] Using attachement strategy of brpc to send packet with big size." #4267

merged 1 commit into from
Aug 6, 2020

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Aug 6, 2020

Reverts #4237

morningman
morningman approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This commit can cause coredump.

@wuyunfeng wuyunfeng added approved Indicates a PR has been approved by one committer. area/aarch64 Issues or PRs related to the aarch64 platform and removed area/aarch64 Issues or PRs related to the aarch64 platform labels Aug 6, 2020
@morningman morningman merged commit b62ff85 into master Aug 6, 2020
@yangzhg yangzhg deleted the revert-4237-master branch February 7, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaoyli @morningman @wuyunfeng