Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix core when modifing char to varchar and loading boolean with replace aggregation #4042

Merged
merged 1 commit into from
Jul 8, 2020
Merged

[Bug] Fix core when modifing char to varchar and loading boolean with replace aggregation #4042

merged 1 commit into from
Jul 8, 2020

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Jul 7, 2020

  1. Doris support modify char to varchar. There is a bug when use two-level pointer when converting the date.
  2. Boolean can be used as metric value with REPLACE and REPLACE_IF_NOT_NULL aggregation function. The aggregation function should be added into aggregation map.

@chaoyli chaoyli self-assigned this Jul 7, 2020
This was linked to issues Jul 7, 2020
Core upon modifing char to varchar #4043
Closed
Core upon modifing char to varchar #4044
Closed
morningman
morningman approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added area/schema-change Issues or PRs related to schema change kind/fix Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by one committer. labels Jul 7, 2020
@chaoyli chaoyli merged commit 413d6d2 into apache:master Jul 8, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2020
@chaoyli @morningman-cmy
[Bug] Fix core when modifing char to varchar and loading boolean with…
bdfdc97 
… replace aggregation (apache#4042)

1. Doris support modify char to varchar. There is a bug when use two-level pointer when converting the date.
2. Boolean can be used as metric value with REPLACE and REPLACE_IF_NOT_NULL aggregation function. The aggregation function should be added into aggregation map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees

@chaoyli chaoyli

Labels
approved Indicates a PR has been approved by one committer. area/schema-change Issues or PRs related to schema change kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core upon modifing char to varchar Core upon modifing char to varchar
2 participants
@chaoyli @morningman