Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clear Txn when load been cancelled #3766

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[Bug] Clear Txn when load been cancelled #3766

merged 1 commit into from
Jun 4, 2020

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Jun 3, 2020

If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.

@chaoyli chaoyli self-assigned this Jun 3, 2020
@chaoyli chaoyli linked an issue Jun 3, 2020 that may be closed by this pull request
@chaoyli chaoyli added the kind/fix Categorizes issue or PR as related to a bug. label Jun 3, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue to describe the bug you met

If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
@chaoyli
Copy link
Contributor Author

chaoyli commented Jun 4, 2020

Please create an issue to describe the bug you met

I have already linked issues.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jun 4, 2020
@chaoyli chaoyli merged commit 9b2cf1c into apache:master Jun 4, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Jun 7, 2020
If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
baidu-doris pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jun 17, 2020
If you a load task encoutering error, it will be cancelled.
At this time, FE will clear the Txn according to the DbName.
In FE, DbName should be added by cluter name.
If missing cluster name, it will encounter NullPointer.
As a result, the Txn will still exists until timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Txn is not cleared when load been cancelled.
2 participants