[improvement](mtmv) Remove useless code and add some doc #32047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
TPC-H: Total hot run time: 37884 ms |
TPC-DS: Total hot run time: 186442 ms |
ClickBench: Total hot run time: 30.79 s |
morrySnow
approved these changes
Mar 13, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Mar 13, 2024
Comment on lines
+65
to
+73
| Plan mvPlan = originPlan.accept(new DefaultPlanRewriter<Object>() { | ||
| @Override | ||
| public Plan visit(Plan plan, Object context) { | ||
| if (plan instanceof LogicalResultSink) { | ||
| return ((LogicalResultSink<Plan>) plan).child(); | ||
| } | ||
| return super.visit(plan, context); | ||
| } | ||
| }, null); |
There was a problem hiding this comment.
minor:
alternative 1:
new DefaultPlanRewriter<Object>() {
@Override
public Plan visitLogicalResultSink(LogicalResultSink sink, Object context) {
return plan.child().accept(this, context);
}
}alternative 2:
Plan mvPlan = originPlan.rewriteUp(p -> p instanceof LogicalResultSink ? p.child(0) : p)
yiguolei
pushed a commit
that referenced
this pull request
Mar 15, 2024
1. Use visitor to remove the result sink in mv plan 2. Remove useless code 3. Add more doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...