[improvement](mtmv) Improve the performance for query rewritting by materialized view #31886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
morrySnow
reviewed
Mar 7, 2024
| @@ -1578,6 +1581,10 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { | |||
| "whether to use a materialized view that contains the foreign table " | |||
| + "when using rewriting based on struct info"}) | |||
| public boolean materializedViewRewriteEnableContainExternalTable = false; | |||
| @VariableMgr.VarAttr(name = MATERIALIZED_VIEW_REWRITE_SUCCESS_CANDIDATE_NUM, needForward = true, | |||
| description = {"透明改写成功的结果集合，允许参与到CBO候选的最大数量", | |||
There was a problem hiding this comment.
Suggested change
| description = {"透明改写成功的结果集合，允许参与到CBO候选的最大数量", | |
| description = {"异步物化视图透明改写成功的结果集合，允许参与到CBO候选的最大数量", |
| @@ -150,13 +155,17 @@ public void setSuccess(boolean success) { | |||
| /** | |||
| * recordFailReason | |||
| */ | |||
| public void recordFailReason(ObjectId objectId, Pair<String, String> summaryAndReason) { | |||
| public void recordFailReason(StructInfo structInfo, Pair<String, String> summaryAndReason) { | |||
There was a problem hiding this comment.
maybe use this signature is better
Suggested change
| public void recordFailReason(StructInfo structInfo, Pair<String, String> summaryAndReason) { | |
| public void recordFailReason(StructInfo structInfo, String summary, Supplier<String> reasonSupplier) { | |
| ... | |
| String reason = enableRecordFailureDetail ? reasonSupplier.get() : "" | |
| ... |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
seawinde
force-pushed
the
performance_optimize
branch
from
8347f3b to
d41189f
Compare
|
run buildall |
keanji-x
approved these changes
Mar 8, 2024
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Mar 8, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Mar 9, 2024
…aterialized view (#31886) - Limit the number of times for the query rewritting to the group - Remove the unnecessary log and explain detail info in query
yiguolei
pushed a commit
that referenced
this pull request
Mar 9, 2024
…aterialized view (#31886) - Limit the number of times for the query rewritting to the group - Remove the unnecessary log and explain detail info in query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...