[fix](plan) only scan node with limit and no predicate can reduce to 1 instance #31342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
yiguolei
approved these changes
Feb 23, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Feb 23, 2024
…1 instance (#31342) This PR #25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Feb 29, 2024
…1 instance (apache#31342) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 1, 2024
…1 instance (apache#31342) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
morningman
added a commit
that referenced
this pull request
Mar 1, 2024
…1 instance (#31342) (#31606) This PR #25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…1 instance (apache#31342) (apache#31606) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR #25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory.
But this is wrong because we can not guarantee that the predicates can truly help to prune the data.
So I modify the logic to remove this opt.
Now, only scan node with limit and NO predicate can reduce to only 1 instance.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...