-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement](docs) Clarify the requirement for JDK exact version 8 in install guide #29921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run buildall |
adonis0147
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jan 14, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 15, 2024
…n install guide (apache#29921) * docs: Clarified the requirement for JDK exact version 8 * fix: Update code
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 15, 2024
…n install guide (apache#29921) * docs: Clarified the requirement for JDK exact version 8 * fix: Update code
yiguolei
pushed a commit
that referenced
this pull request
Jan 16, 2024
…n install guide (#29921) * docs: Clarified the requirement for JDK exact version 8 * fix: Update code
larshelge
added a commit
to larshelge/doris
that referenced
this pull request
Feb 26, 2024
…n install guide (apache#29921) * docs: Clarified the requirement for JDK exact version 8 * fix: Update code (cherry picked from commit a346408)
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…n install guide (apache#29921) (apache#31437) * docs: Clarified the requirement for JDK exact version 8 * fix: Update code (cherry picked from commit a346408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.6-merged
dev/3.0.0-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the requirement for JDK exact version 8.
When reading the install guides, it was not fully clear that exactly version 8 of the JDK is required. Requirements for other software refers to "and above", and it is a bit unusual to require exactly JDK 8.
The patch also makes some minor improvements to the language and consistency in the quick start and standard deployment guides.