Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](docs) Clarify the requirement for JDK exact version 8 in install guide #29921

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Conversation

larshelge
Copy link
Contributor

Clarifies the requirement for JDK exact version 8.

When reading the install guides, it was not fully clear that exactly version 8 of the JDK is required. Requirements for other software refers to "and above", and it is a bit unusual to require exactly JDK 8.

The patch also makes some minor improvements to the language and consistency in the quick start and standard deployment guides.

@larshelge larshelge changed the title docs: Clarify the requirement for JDK exact version 8 in install guides docs: Clarify the requirement for JDK exact version 8 in install guide Jan 12, 2024
@adonis0147
Copy link
Contributor

run buildall

Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 changed the title docs: Clarify the requirement for JDK exact version 8 in install guide [enhancement](docs) Clarify the requirement for JDK exact version 8 in install guide Jan 12, 2024
@yiguolei yiguolei merged commit a346408 into apache:master Jan 14, 2024
18 of 20 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 15, 2024
…n install guide (apache#29921)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code
seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 15, 2024
…n install guide (apache#29921)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code
yiguolei pushed a commit that referenced this pull request Jan 16, 2024
…n install guide (#29921)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code
larshelge added a commit to larshelge/doris that referenced this pull request Feb 26, 2024
…n install guide (apache#29921)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code

(cherry picked from commit a346408)
yiguolei pushed a commit that referenced this pull request Feb 28, 2024
…n install guide (#29921) (#31437)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code

(cherry picked from commit a346408)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…n install guide (apache#29921) (apache#31437)

* docs: Clarified the requirement for JDK exact version 8

* fix: Update code

(cherry picked from commit a346408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.6-merged dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants