[Improvement](nereids) Support join derivation when mv rewrite #29609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seawinde
force-pushed
the
support_join_derivation_when_mv_rewrite
branch
from
bdcf648 to
5fe7e10
Compare
|
run buildall |
TPC-H: Total hot run time: 38601 ms |
TPC-DS: Total hot run time: 184660 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H: Total hot run time: 38382 ms |
TPC-DS: Total hot run time: 184043 ms |
keanji-x
reviewed
Jan 8, 2024
Comment on lines
445
to
417
| return SplitPredicate.empty(); | ||
| } |
There was a problem hiding this comment.
what is empty splitPredicate meaning
There was a problem hiding this comment.
Maybe an invalid instance is better
There was a problem hiding this comment.
this means invalid, i will change it more semantic
keanji-x
reviewed
Jan 8, 2024
| comparisonResult); | ||
| // if the join type in query and mv plan is different, we should check and add filter on mv to make | ||
| // the mv join type is accord with query | ||
| Set<Set<Slot>> viewNoNullableSlot = comparisonResult.getViewNoNullableSlot(); |
There was a problem hiding this comment.
maybe requireNoNullableSlot name is better
keanji-x
reviewed
Jan 8, 2024
Comment on lines
443
to
444
| if (viewNoNullableSlot.stream().anyMatch( | ||
| set -> Sets.intersection(set, queryUsedRejectNullSlotsViewBased).isEmpty())) { |
There was a problem hiding this comment.
empty splitPredicate is invalid, so this should be anymatch
morrySnow
reviewed
Jan 8, 2024
| @@ -39,4 +43,9 @@ public FunctionSignature customSignature() { | |||
| return FunctionSignature.ret(dataType).args(dataType); | |||
| } | |||
|
|
|||
| @Override | |||
| public Expression withChildren(List<Expression> children) { | |||
| Preconditions.checkArgument(children.size() == 1); | |||
| @@ -39,4 +43,9 @@ public FunctionSignature customSignature() { | |||
| return FunctionSignature.ret(dataType).args(dataType); | |||
| } | |||
|
|
|||
| @Override | |||
| public Expression withChildren(List<Expression> children) { | |||
| Preconditions.checkArgument(children.size() == 1); | |||
seawinde
force-pushed
the
support_join_derivation_when_mv_rewrite
branch
2 times, most recently
from
199a7ce to
10c402c
Compare
|
run buildall |
TPC-H: Total hot run time: 38887 ms |
keanji-x
approved these changes
Jan 8, 2024
TPC-DS: Total hot run time: 184691 ms |
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
previously approved these changes
Jan 8, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
seawinde
force-pushed
the
support_join_derivation_when_mv_rewrite
branch
from
1fcbc71 to
7119dc1
Compare
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 38539 ms |
TPC-DS: Total hot run time: 184953 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
approved these changes
Jan 9, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Jan 12, 2024
materialized view def is as following: > select l_linenumber, o_custkey > from orders > left join lineitem on lineitem.L_ORDERKEY = orders.O_ORDERKEY > where o_custkey = 1; when query is as following, it can be rewritten by mv above it requires that query has reject null filters on the join right input, current supported filter are "=", "<", "<=", ">", ">=", "<=>" > select IFNULL(orders.O_CUSTKEY, 0) as custkey_not_null, > case when l_linenumber in (1,2,3) then l_linenumber else o_custkey end as case_when > from orders > inner join lineitem on orders.O_ORDERKEY = lineitem.L_ORDERKEY > where o_custkey = 1 and l_linenumber > 0;
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…e#29609) materialized view def is as following: > select l_linenumber, o_custkey > from orders > left join lineitem on lineitem.L_ORDERKEY = orders.O_ORDERKEY > where o_custkey = 1; when query is as following, it can be rewritten by mv above it requires that query has reject null filters on the join right input, current supported filter are "=", "<", "<=", ">", ">=", "<=>" > select IFNULL(orders.O_CUSTKEY, 0) as custkey_not_null, > case when l_linenumber in (1,2,3) then l_linenumber else o_custkey end as case_when > from orders > inner join lineitem on orders.O_ORDERKEY = lineitem.L_ORDERKEY > where o_custkey = 1 and l_linenumber > 0;
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Jan 24, 2024
…e#29609) materialized view def is as following: > select l_linenumber, o_custkey > from orders > left join lineitem on lineitem.L_ORDERKEY = orders.O_ORDERKEY > where o_custkey = 1; when query is as following, it can be rewritten by mv above it requires that query has reject null filters on the join right input, current supported filter are "=", "<", "<=", ">", ">=", "<=>" > select IFNULL(orders.O_CUSTKEY, 0) as custkey_not_null, > case when l_linenumber in (1,2,3) then l_linenumber else o_custkey end as case_when > from orders > inner join lineitem on orders.O_ORDERKEY = lineitem.L_ORDERKEY > where o_custkey = 1 and l_linenumber > 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
materialized view def is as following:
when query is as following, it can be rewritten by mv above
it requires that query has reject null filters on the join right input,
current supported filter are "=", "<", "<=", ">", ">=", "<=>"
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...