Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pick](branch-2.0) pick some PRs about point query optimization #28611

Merged
merged 3 commits into from
Dec 19, 2023
Merged

[Pick](branch-2.0) pick some PRs about point query optimization #28611

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecb5c8
[Fix](point query) fix memleak by increasing `scanReplicaIds` when us…
eldenmoon Dec 8, 2023
559e855
[Performance](point query)Opimize partition prune for point query (#2…
eldenmoon Dec 19, 2023
45dc2d3
[Improve](sort) avoid too may tmp vectors for get_columns (#27734)
eldenmoon Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Improve](sort) avoid too may tmp vectors for get_columns (#27734)
  • Loading branch information
@eldenmoon
eldenmoon committed Dec 19, 2023
commit 45dc2d3f4aede3be34cde3e1036f95f3594ebd36
3 changes: 2 additions & 1 deletion be/src/vec/common/sort/heap_sorter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ Status HeapSorter::prepare_for_read() {
for (int i = capacity - 1; i >= 0; i--) {
auto rid = vector_to_reverse[i].row_id();
const auto cur_block = vector_to_reverse[i].block();
Columns columns = cur_block->get_columns();
for (size_t j = 0; j < num_columns; ++j) {
result_columns[j]->insert_from(*(cur_block->get_columns()[j]), rid);
result_columns[j]->insert_from(*(columns[j]), rid);
}
}
_return_block = vector_to_reverse[0].block()->clone_with_columns(std::move(result_columns));
Expand Down