Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression test](control) add some regression case for control #27346

Merged
merged 4 commits into from
Nov 24, 2023
Merged

[regression test](control) add some regression case for control #27346

merged 4 commits into from
Nov 24, 2023

Conversation

deardeng
Copy link
Contributor

Proposed changes

add some regression

1. CANCEL DECOMMISSION BACKEND
2. SET REPLICA STATUS
3. CLEAN TRASH
4. SET REPLICA VERSION
5. BAD REPLICA

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@deardeng
[regression test](control) add some regression case for control
870dac2 
```
1. CANCEL DECOMMISSION BACKEND
2. SET REPLICA STATUS
3. CLEAN TRASH
4. SET REPLICA VERSION
5. BAD REPLICA
```
@deardeng
fix
ed67cd7
@deardeng
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17099582896 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit ed67cd7a702801d223f3e493b9e47829f0b63858, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4911	4696	4702	4696
q2	381	177	158	158
q3	2045	1922	1862	1862
q4	1379	1249	1239	1239
q5	3977	3930	4010	3930
q6	249	127	128	127
q7	1412	881	893	881
q8	2728	2759	2753	2753
q9	25576	13032	9575	9575
q10	10249	3531	3510	3510
q11	402	239	246	239
q12	468	304	298	298
q13	4572	3790	3824	3790
q14	330	298	292	292
q15	602	537	529	529
q16	680	584	585	584
q17	1129	977	914	914
q18	7761	7292	7370	7292
q19	1708	1668	1658	1658
q20	579	299	303	299
q21	4434	3956	3967	3956
q22	481	382	368	368
Total cold run time: 76053 ms
Total hot run time: 48950 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4616	4574	4562	4562
q2	351	219	239	219
q3	4037	3995	4002	3995
q4	2734	2723	2701	2701
q5	9593	9571	9699	9571
q6	239	124	126	124
q7	3019	2485	2496	2485
q8	4384	4423	4431	4423
q9	13170	13127	13082	13082
q10	4107	4211	4229	4211
q11	766	721	647	647
q12	978	841	822	822
q13	4311	3618	3565	3565
q14	405	348	349	348
q15	589	519	536	519
q16	742	678	684	678
q17	3965	3903	3842	3842
q18	9473	8824	8961	8824
q19	1836	1781	1793	1781
q20	2362	2088	2031	2031
q21	8806	8675	8771	8675
q22	914	830	821	821
Total cold run time: 81397 ms
Total hot run time: 77926 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.52% (8446/23125)
Line Coverage: 28.85% (68648/237963)
Region Coverage: 27.81% (35503/127658)
Branch Coverage: 24.56% (18101/73694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ed67cd7a702801d223f3e493b9e47829f0b63858_ed67cd7a702801d223f3e493b9e47829f0b63858/report/index.html

@deardeng
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.53% (8448/23124)
Line Coverage: 28.86% (68687/237975)
Region Coverage: 27.82% (35516/127668)
Branch Coverage: 24.58% (18117/73706)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61ddf4918a908ca097f29ad18e265005403291f7_61ddf4918a908ca097f29ad18e265005403291f7/report/index.html

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 61ddf4918a908ca097f29ad18e265005403291f7, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4927	4711	4695	4695
q2	361	171	166	166
q3	2051	1945	1900	1900
q4	1389	1255	1234	1234
q5	3931	3954	4044	3954
q6	248	128	132	128
q7	1464	893	888	888
q8	2727	2780	2747	2747
q9	9710	9859	9558	9558
q10	3478	3560	3525	3525
q11	372	251	244	244
q12	441	293	301	293
q13	4591	3788	3833	3788
q14	325	288	285	285
q15	574	542	518	518
q16	658	579	577	577
q17	1135	928	892	892
q18	7817	7242	7394	7242
q19	1663	1682	1647	1647
q20	519	302	305	302
q21	4395	3979	3958	3958
q22	470	378	370	370
Total cold run time: 53246 ms
Total hot run time: 48911 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4593	4570	4572	4570
q2	334	236	286	236
q3	4022	4012	3985	3985
q4	2700	2704	2696	2696
q5	9707	9583	9615	9583
q6	242	124	125	124
q7	3038	2483	2487	2483
q8	4414	4428	4466	4428
q9	13220	13164	13056	13056
q10	4123	4216	4183	4183
q11	781	648	640	640
q12	986	823	835	823
q13	4321	3594	3567	3567
q14	379	362	343	343
q15	574	525	523	523
q16	746	687	670	670
q17	3822	3879	3887	3879
q18	9430	9003	8946	8946
q19	1801	1768	1774	1768
q20	2407	2097	2075	2075
q21	8797	8622	8773	8622
q22	924	849	758	758
Total cold run time: 81361 ms
Total hot run time: 77958 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.82 seconds
stream load tsv: 587 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17159021060 Bytes

yujun777
yujun777 reviewed Nov 21, 2023
View reviewed changes
dataroaring
dataroaring previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yujun777
yujun777 reviewed Nov 22, 2023
View reviewed changes
yujun777
yujun777 reviewed Nov 22, 2023
View reviewed changes
@deardeng
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yujun777
yujun777 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deardeng
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.52% (8445/23123)
Line Coverage: 28.85% (68668/238023)
Region Coverage: 27.81% (35515/127694)
Branch Coverage: 24.56% (18109/73726)
Coverage Report: http://coverage.selectdb-in.cc/coverage/81ac39c10d0ef2eabf194c8c5c6f489bde6931df_81ac39c10d0ef2eabf194c8c5c6f489bde6931df/report/index.html

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 81ac39c10d0ef2eabf194c8c5c6f489bde6931df, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4884	4650	4654	4650
q2	353	165	161	161
q3	2041	1945	1926	1926
q4	1387	1256	1247	1247
q5	3947	3908	4020	3908
q6	242	132	129	129
q7	1438	892	878	878
q8	2737	2763	2762	2762
q9	9780	9859	9650	9650
q10	10264	3513	3523	3513
q11	380	241	256	241
q12	435	292	294	292
q13	4545	3802	3791	3791
q14	322	295	284	284
q15	592	534	530	530
q16	666	589	581	581
q17	1175	942	934	934
q18	7823	7210	7336	7210
q19	1675	1696	1669	1669
q20	542	322	304	304
q21	4367	3968	3918	3918
q22	479	367	372	367
Total cold run time: 60074 ms
Total hot run time: 48945 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4563	4603	4565	4565
q2	349	244	247	244
q3	4024	3980	3982	3980
q4	2684	2683	2682	2682
q5	9754	9617	9674	9617
q6	241	121	122	121
q7	3026	2484	2462	2462
q8	4414	4417	4460	4417
q9	13237	13085	13099	13085
q10	4096	4182	4200	4182
q11	743	646	633	633
q12	983	824	806	806
q13	4253	3598	3590	3590
q14	388	337	344	337
q15	568	518	531	518
q16	730	671	672	671
q17	3901	3886	3820	3820
q18	9497	8959	9084	8959
q19	1786	1770	1769	1769
q20	2380	2057	2051	2051
q21	8849	8552	8598	8552
q22	856	765	801	765
Total cold run time: 81322 ms
Total hot run time: 77826 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.65 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17099018849 Bytes

dataroaring
dataroaring approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 2152d5a into apache:master Nov 24, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
@deardeng @seawinde
[regression test](control) add some regression case for control (apac…
c22f3c8 
…he#27346)

* [regression test](control) add some regression case for control

```
1. CANCEL DECOMMISSION BACKEND
2. SET REPLICA STATUS
3. CLEAN TRASH
4. SET REPLICA VERSION
5. BAD REPLICA
```
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@deardeng
[regression test](control) add some regression case for control (apac…
c14599b 
…he#27346)

* [regression test](control) add some regression case for control

```
1. CANCEL DECOMMISSION BACKEND
2. SET REPLICA STATUS
3. CLEAN TRASH
4. SET REPLICA VERSION
5. BAD REPLICA
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujun777 yujun777 yujun777 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.4 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deardeng @doris-robot @yujun777 @dataroaring @xiaokang