Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add block split bloom filter #2471

Merged
merged 6 commits into from
Dec 18, 2019
Merged

add block split bloom filter #2471

merged 6 commits into from
Dec 18, 2019

Conversation

kangpinghuang
Copy link
Contributor

  1. use block split bloom filter
  2. build bloom filter against data page
  3. add distinct value to bloom filter
  4. add ordinal index to bloom filter index

Issue: #1389

huangkangping added 3 commits December 16, 2019 18:32
add block split bloom filter
0c53e92 
1. use block split bloom filter
2. add distinct value to bloom filter
3. add ordinal index to bloom filter index
remove unused code
de76a50
optimize variable name
2cb4cad
imay
imay requested changes Dec 16, 2019
View reviewed changes
imay
imay reviewed Dec 17, 2019
View reviewed changes
imay
imay approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit d31f774 into apache:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangpinghuang @imay