-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement](java-udf) java-udf module split to sub modules #20185
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
docs/zh-CN/docs/faq/install-faq.md
Outdated
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/doris/udf/JniUtil | ||
Caused by: java.lang.ClassNotFoundException: org.apache.doris.udf.JniUtil | ||
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/doris/common/jni/utils/JniUtil | ||
Caused by: java.lang.ClassNotFoundException: org.apache.doris.common.jni.utils.JniUtil | ||
``` | ||
需要从官网下载 `apache-doris-java-udf-jar-with-dependencies-1.2.0` 的 Java UDF 函数依赖包,放到 BE 安装目录下的 lib 目录,然后重新启动 BE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this jar need to be renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en ,yes
You need to copy the entire |
|
clang-tidy review says "All clean, LGTM! 👍" |
0eaa56d
to
633487f
Compare
|
|
ceaa772
to
5fcb003
Compare
|
321ebd6
to
066a4ef
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
@@ -38,7 +38,7 @@ | |||
#include "vec/core/block.h" | |||
#include "vec/data_types/data_type_nullable.h" | |||
|
|||
const char* EXECUTOR_CLASS = "org/apache/doris/udf/UdfExecutor"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here seems error, udaf is under be/src/vec/aggregate_functions/aggregate_function_java_udaf.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I will fix it.
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#20740) Follow #20185 Move all BE java extension jars to `be/lib/java_extensions/` dir. Also remove `udf` dir, used for BE native udf, which is deprecated since v1.2 The final output is: ``` output ├── be │ ├── bin │ ├── conf │ ├── dict │ ├── lib | ├── java_extensions │ ├── hudi-scanner-jar-with-dependencies.jar │ ├── java-udf-jar-with-dependencies.jar │ ├── jdbc-scanner-jar-with-dependencies.jar │ ├── max-compute-scanner-jar-with-dependencies.jar │ └── paimon-scanner-jar-with-dependencies.jar │ ├── LICENSE-dist.txt │ ├── licenses │ ├── log │ ├── NOTICE.txt │ ├── storage │ └── www └── fe ├── bin ├── conf ├── doris-meta ├── lib ├── LICENSE-dist.txt ├── licenses ├── log ├── mysql_ssl_default_certificate ├── NOTICE.txt ├── spark-dpp └── webroot ```
apache#20740) Follow apache#20185 Move all BE java extension jars to `be/lib/java_extensions/` dir. Also remove `udf` dir, used for BE native udf, which is deprecated since v1.2 The final output is: ``` output ├── be │ ├── bin │ ├── conf │ ├── dict │ ├── lib | ├── java_extensions │ ├── hudi-scanner-jar-with-dependencies.jar │ ├── java-udf-jar-with-dependencies.jar │ ├── jdbc-scanner-jar-with-dependencies.jar │ ├── max-compute-scanner-jar-with-dependencies.jar │ └── paimon-scanner-jar-with-dependencies.jar │ ├── LICENSE-dist.txt │ ├── licenses │ ├── log │ ├── NOTICE.txt │ ├── storage │ └── www └── fe ├── bin ├── conf ├── doris-meta ├── lib ├── LICENSE-dist.txt ├── licenses ├── log ├── mysql_ssl_default_certificate ├── NOTICE.txt ├── spark-dpp └── webroot ```
Proposed changes
Issue Number: close #19977
The java-udf module has become increasingly large and difficult to manage, making it inconvenient to package and use as needed. It needs to be split into multiple sub-modules, such as : java-commom、java-udf、jdbc-scanner、hudi-scanner、 paimon-scanner.
Further comments
the java-commom project Includes jni and common function.