[opt](hashtable) Modify default filled strategy to 75% #18242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
#10936 introduces the allow when the capacity of the Hash Table is greater than 2G, it starts to grow when 75% of the capacity is satisfied
#11944 On version 1.1.2 when the capacity of the Hash Table is greater than 64M it starts to grow when 75% of the capacity is satisfied, no performance issues have been found in version 1.1.x.
So on the master, we default to 75% expansion when the HashTable is larger than 2G, and expect to apply it to 1.2.x and later versions
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...