[chore](macOS) Use LLVM Clang by default #17292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind/docs
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
This was referenced Mar 3, 2023
[chore](github) Use LLVM Clang to build the libraries by default on macOS
apache/doris-thirdparty#41
Merged
adonis0147
added a commit
that referenced
this pull request
Mar 3, 2023
#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
Use LLVM Clang by default
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
Use LLVM Clang by default
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
adonis0147
added a commit
to adonis0147/doris
that referenced
this pull request
Apr 24, 2023
Use LLVM Clang by default
adonis0147
added a commit
to adonis0147/doris
that referenced
this pull request
Apr 24, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
5 tasks
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
Backport: 1. [chore](macOS) Use LLVM Clang by default apache#17292 2. [chore](workflow) Fix the workflow BE UT (macOS) apache#17403 3. [chore](macOS) Disable detect_container_overflow at BE startup apache#17514 4. [chore](macOS) Specify the version of LLVM for Homebrew to install it apache#17945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use LLVM Clang to build the project by default on macOS.
Problem summary
Currently, we use Apple Clang to build the project on macOS. It is inconvenient for users who use legacy operation systems to upgrade the toolchains because the toolchains have a requirement about the version of OS (See https://xcodereleases.com/).
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...