Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show storage policy null pointer and redundant log #10906

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

deardeng
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

kpfly
kpfly previously approved these changes Jul 16, 2022
Copy link

@kpfly kpfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Jul 16, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2022
@deardeng deardeng dismissed stale reviews from dataroaring and kpfly via 7ac92f6 July 16, 2022 13:54
@deardeng deardeng force-pushed the fix-show-storage-policy branch from 8c94f09 to 7ac92f6 Compare July 16, 2022 13:54
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 16, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 8c544b6 into apache:master Jul 18, 2022
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
* fix show storage policy null pointer and redundant log
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
* fix show storage policy null pointer and redundant log
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 1, 2022
* fix show storage policy null pointer and redundant log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants