[fix-585] fixed the issue of not handle negative values when process the accuracy range of datetime #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e accuracy range of timestamp
JNSimba
reviewed
Apr 21, 2025
| } else if (time > -10_000_000_000_000L && time < 10_000_000_000_000L) { // milli second | ||
| instant = Instant.ofEpochMilli(time); | ||
| } else { // micro second | ||
| instant = Instant.ofEpochSecond(time / 1_000_000, (time % 1_000_000) * 1_000); |
There was a problem hiding this comment.
It is better to add a case to cover the lower boundary value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e accuracy range of timestamp
Proposed changes
Issue Number: close #585
Problem Summary:
fixed the issue of not handling negative values when process the accuracy range of timestamp
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...