-
Notifications
You must be signed in to change notification settings - Fork 1.5k
consolidate datafusion docs with sphinx #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe this is the last missing piece before we can prepare for the 5.1.0 release. |
00f24ab
to
51ed30a
Compare
* added python doc * combined, cli, user-guide and specification docs into a single datafusion doc Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
@@ -0,0 +1,38 @@ | |||
# Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated by sphinx
@@ -0,0 +1,52 @@ | |||
@rem Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated by sphinx
@@ -0,0 +1,93 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from arrow
@@ -0,0 +1,19 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from arrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it for a spin and it worked great 👍 Really nice @houqp
@jimexist since you put in a lot of efforts into building out the python doc, do you mind taking a look at this PR? |
generally LGTM, i might want to improve on the |
i think that #977 can go after you merge this - which i'll try to update |
🎉 📖 |
* Start working on GetArrayStructFIelds * Almost have working * Working * Add another test * Remove unused * Remove unused sql conf
* Start working on GetArrayStructFIelds * Almost have working * Working * Add another test * Remove unused * Remove unused sql conf
Co-authored-by: Jiayu Liu Jimexist@users.noreply.github.com
Which issue does this PR close?
Closes #837
Closes #18
Relates to #18
Rationale for this change
This PR builds on top of the great work @jimexist did with our Python binding doc.
In summary, the suggestion from the arrow PR was to host the Python binding doc in our a website dedicated to datafusion instead of in Arrow's documentation page. Then link to the Datafusion documentation from Arrow home page's top banner.
Following the plan outlined at apache/arrow#10982 (comment), this PR consolidates all docs into a single doc website so we can use it as the home page for Datafusion (to be hosted at https://arrow.apache.org/datafusion). The Python binding doc prepared by @jimexist will be hosted as one of the sections in the Datafusion doc.
Once this PR is merged, I will generate the docs and send the full html build as a PR to the arrow-site repo.
What changes are included in this PR?
Are there any user-facing changes?
No
Here is what the documentation looks like: