Skip to content

consolidate datafusion docs with sphinx #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Conversation

houqp
Copy link
Member

@houqp houqp commented Sep 13, 2021

Co-authored-by: Jiayu Liu Jimexist@users.noreply.github.com

Which issue does this PR close?

Closes #837
Closes #18
Relates to #18

Rationale for this change

This PR builds on top of the great work @jimexist did with our Python binding doc.

In summary, the suggestion from the arrow PR was to host the Python binding doc in our a website dedicated to datafusion instead of in Arrow's documentation page. Then link to the Datafusion documentation from Arrow home page's top banner.

Following the plan outlined at apache/arrow#10982 (comment), this PR consolidates all docs into a single doc website so we can use it as the home page for Datafusion (to be hosted at https://arrow.apache.org/datafusion). The Python binding doc prepared by @jimexist will be hosted as one of the sections in the Datafusion doc.

Once this PR is merged, I will generate the docs and send the full html build as a PR to the arrow-site repo.

What changes are included in this PR?

  • added python doc
  • combined, cli, user-guide and specification docs into a single datafusion doc

Are there any user-facing changes?

No

Here is what the documentation looks like:

df-doc

df-doc-2

@houqp houqp requested a review from alamb September 13, 2021 01:25
@github-actions github-actions bot added datafusion Changes in the datafusion crate documentation Improvements or additions to documentation labels Sep 13, 2021
@houqp houqp added this to the 5.1.0 milestone Sep 13, 2021
@houqp
Copy link
Member Author

houqp commented Sep 13, 2021

I believe this is the last missing piece before we can prepare for the 5.1.0 release.

@houqp houqp force-pushed the qp_df_docs branch 2 times, most recently from 00f24ab to 51ed30a Compare September 13, 2021 01:41
* added python doc
* combined, cli, user-guide and specification docs into a single datafusion doc

Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
@@ -0,0 +1,38 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated by sphinx

@@ -0,0 +1,52 @@
@rem Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated by sphinx

@@ -0,0 +1,93 @@
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from arrow

@@ -0,0 +1,19 @@

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from arrow

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it for a spin and it worked great 👍 Really nice @houqp

Screen Shot 2021-09-13 at 1 37 50 PM

@houqp
Copy link
Member Author

houqp commented Sep 14, 2021

@jimexist since you put in a lot of efforts into building out the python doc, do you mind taking a look at this PR?

@jimexist
Copy link
Member

generally LGTM, i might want to improve on the requirements.txt for reproducible builds but that's to be done in subsequent PRs.

@jimexist
Copy link
Member

i think that #977 can go after you merge this - which i'll try to update .ast files instead

@houqp houqp merged commit dcd34c6 into apache:master Sep 15, 2021
@houqp houqp deleted the qp_df_docs branch September 15, 2021 05:16
@alamb
Copy link
Contributor

alamb commented Sep 15, 2021

🎉 📖

andygrove pushed a commit to andygrove/datafusion that referenced this pull request Jan 31, 2025
* Start working on GetArrayStructFIelds

* Almost have working

* Working

* Add another test

* Remove unused

* Remove unused sql conf
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
* Start working on GetArrayStructFIelds

* Almost have working

* Working

* Add another test

* Remove unused

* Remove unused sql conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release documentation for python binding Consider using GitHub pages for DataFusion/Ballista documentation
4 participants