Fix group by aliased expression in LogicalPLanBuilder::aggregate #8629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
commented
Dec 22, 2023
| /// | ||
| /// This allows MySQL style selects like | ||
| /// `SELECT col FROM t WHERE pk = 5` if col is unique | ||
| fn add_group_by_exprs_from_dependencies( |
Contributor
Author
There was a problem hiding this comment.
I pulled the logic into its own function so I could document it better
| let expr = | ||
| Expr::Column(Column::new(field.qualifier().cloned(), field.name())); | ||
| let expr_name = expr.display_name()?; | ||
| if !group_by_field_names.contains(&expr_name) { |
Contributor
Author
There was a problem hiding this comment.
this is the change -- rather than comparing the Exprs it compares their display_name (the fields they will create)
mustafasrepo
approved these changes
Dec 25, 2023
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
Thanks @alamb LGTM!
Contributor
Author
|
Thank you for the review @mustafasrepo |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 1, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 2, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 2, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 3, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 3, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 4, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8628
Rationale for this change
Fixed regression introduced in #8356 as explained on #8628
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Fix bug