Minor: port last test from parquet.rs #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
7 tasks
alamb
force-pushed
the
alamb/port_last_parquet
branch
from
c4a0082
to
a9536d1
Compare
alamb
commented
Dec 19, 2023
| let int_list_array = as_list_array(batch.column(0)).unwrap(); | ||
| let utf8_list_array = as_list_array(batch.column(1)).unwrap(); | ||
|
|
||
| assert_eq!( |
There was a problem hiding this comment.
This equality check predates the ability to print out ListArrays
comphead
approved these changes
Dec 20, 2023
|
Thank you for the review @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #8560
Related to #8206.
Rationale for this change
While porting tests in parquet.rs to sqllogictests @hiltontj noticed there was a disabled test that could be ported.
The test predates most of DataFusion / the parquet crate's ability to read structured data / arrow-rs's ability to print it so it was somewhat akward in its original form. Given the better support now things are in much better shape
What changes are included in this PR?
Are these changes tested?
all tests