fix: check for precision overflow when parsing float as decimal #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 22, 2023
datafusion/sql/src/expr/value.rs
Outdated
| ))) | ||
| })?; | ||
|
|
||
| const MAX_DECIMAL_128_VALUE: i128 = 10_i128.pow(38) - 1; |
There was a problem hiding this comment.
Perhaps using https://docs.rs/arrow/latest/arrow/datatypes/constant.DECIMAL128_MAX_PRECISION.html would be clearer than 38 here
There was a problem hiding this comment.
Fixed. Thank you @alamb .
jonahgao
commented
Sep 23, 2023
| let number = parse_decimal_128_without_scale(str)?; | ||
| Ok(Expr::Literal(ScalarValue::Decimal128( | ||
| Some(number), | ||
| str.len() as u8, |
There was a problem hiding this comment.
Try to use the minimum precision instead of the maximum precision.
jonahgao
commented
Sep 23, 2023
| @@ -82,3 +82,72 @@ set datafusion.execution.batch_size = 8192; | |||
|
|
|||
| statement ok | |||
| drop table a | |||
|
|
|||
There was a problem hiding this comment.
Move the tests to options.slt. I think those tests are not related to DDL.
alamb
approved these changes
Sep 25, 2023
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
…he#7627) * fix: check for precision overflow when parsing float as decimal * fix hard-coded precison and move tests to options.slt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7626.
Rationale for this change
A decimal data could exceed its maximum precision limit without exceeding the maximum value of
i128.What changes are included in this PR?
Check for precision overflow when parsing float as decimal
Are these changes tested?
Yes
Are there any user-facing changes?
No