Minor(proto): Implement TryFrom<&DFSchema>
for protobuf::DfSchema
#7505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Currently, we have only implemented
TryFrom<&DFSchemaRef>
forprotobuf::DfSchema
.In the example below, when encoding a
DFSchema
, we have to create anArc
, which can be considered wasteful.Implementing
TryFrom<&DFSchema>
forprotobuf::DfSchema
helps to avoid this issue,and then the code is simplified as follows.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
New API, without breaking changes