Skip to content

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Jul 16, 2021

Which issue does this PR close?

Closes #739

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Dandandan Dandandan changed the title WIP: Support table column alias WIP: Support table columns alias Jul 16, 2021
@Dandandan Dandandan changed the title WIP: Support table columns alias Support table columns alias Jul 17, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @Dandandan

fn table_with_column_alias() {
let sql = "SELECT a, b, c
FROM lineitem l (a, b, c)";
let expected = "Projection: #a, #b, #c\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan Dandandan merged commit 666360b into apache:master Jul 18, 2021
@alamb
Copy link
Contributor

alamb commented Jul 18, 2021

🎉

@houqp houqp added the enhancement New feature or request label Jul 31, 2021
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
* fix: Supported nested types in HashJoin

* Update diffs ignore new failing specs

Needs to be ignored for the same reason as the other specs in the
DynamicPartitionPruningSuiteBase. But previously we did not hit the
issue as we did not support the join being done.

* Improve type support check

* Improve tests

* Remove unneeded supportedDataType guard
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
* fix pushdown for pyarrow filter IsNull

The conversion was incorrectly passing in the expression itself as the `nan_as_null` argument. This caused the pushdown to silently fail.

* expand the Expr::Literal's that can be used in PyArrowFilterExpression

Closes apache#703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support column names alias

3 participants