-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support table columns alias #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 17, 2021
Contributor
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks @Dandandan
| fn table_with_column_alias() { | ||
| let sql = "SELECT a, b, c | ||
| FROM lineitem l (a, b, c)"; | ||
| let expected = "Projection: #a, #b, #c\ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Contributor
|
🎉 |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* fix: Supported nested types in HashJoin * Update diffs ignore new failing specs Needs to be ignored for the same reason as the other specs in the DynamicPartitionPruningSuiteBase. But previously we did not hit the issue as we did not support the join being done. * Improve type support check * Improve tests * Remove unneeded supportedDataType guard
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* fix pushdown for pyarrow filter IsNull The conversion was incorrectly passing in the expression itself as the `nan_as_null` argument. This caused the pushdown to silently fail. * expand the Expr::Literal's that can be used in PyArrowFilterExpression Closes apache#703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #739
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?