Fixes for clippy 1.71 #6959
Merged
Fixes for clippy 1.71 #6959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 13, 2023
| @@ -68,6 +68,15 @@ const SEED: RandomState = RandomState::with_seeds( | |||
| 0x0eaea5d736d733a4_u64, | |||
| ); | |||
|
|
|||
| impl<T> Default for HyperLogLog<T> | |||
There was a problem hiding this comment.
Not sure why clippy wants this, but here it is
alamb
commented
Jul 13, 2023
| @@ -4161,3 +4154,10 @@ impl TableSource for EmptyTable { | |||
| self.table_schema.clone() | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
moved this to the end of the file
viirya
approved these changes
Jul 13, 2023
This was referenced Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6958
Rationale for this change
Clippy got an upgrade and was complaining about new things
What changes are included in this PR?
Do what clippy told me: implement a
Defaultand move something in testsAre these changes tested?
Are there any user-facing changes?