-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Improve aggregate test coverage more #6952
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2048,69 +2048,101 @@ CREATE TABLE test_table (c1 INT, c2 INT, c3 INT) | |
|
||
# Inserting data | ||
statement ok | ||
INSERT INTO test_table VALUES (1, 10, 50), (1, 20, 60), (2, 10, 70), (2, 20, 80), (3, 10, NULL) | ||
INSERT INTO test_table VALUES | ||
(1, 10, 50), | ||
(1, 20, 60), | ||
(2, 10, 70), | ||
(2, 20, 80), | ||
(3, 10, NULL) | ||
|
||
# query_group_by_with_filter | ||
query II rowsort | ||
SELECT c1, SUM(c2) FILTER (WHERE c2 >= 20) as result FROM test_table GROUP BY c1 | ||
query III rowsort | ||
SELECT | ||
c1, | ||
SUM(c2) FILTER (WHERE c2 >= 20), | ||
SUM(c2) FILTER (WHERE c2 < 1) -- no rows pass filter, so the output should be NULL | ||
FROM test_table GROUP BY c1 | ||
---- | ||
1 20 | ||
2 20 | ||
3 NULL | ||
1 20 NULL | ||
2 20 NULL | ||
3 NULL NULL | ||
|
||
# query_group_by_avg_with_filter | ||
query IR rowsort | ||
SELECT c1, AVG(c2) FILTER (WHERE c2 >= 20) AS avg_c2 FROM test_table GROUP BY c1 | ||
query IRR rowsort | ||
SELECT | ||
c1, | ||
AVG(c2) FILTER (WHERE c2 >= 20), | ||
AVG(c2) FILTER (WHERE c2 < 1) -- no rows pass filter, so output should be null | ||
FROM test_table GROUP BY c1 | ||
---- | ||
1 20 | ||
2 20 | ||
3 NULL | ||
1 20 NULL | ||
2 20 NULL | ||
3 NULL NULL | ||
|
||
# query_group_by_with_multiple_filters | ||
query IIR rowsort | ||
SELECT c1, SUM(c2) FILTER (WHERE c2 >= 20) AS sum_c2, AVG(c3) FILTER (WHERE c3 <= 70) AS avg_c3 FROM test_table GROUP BY c1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was just some whitespace OCD |
||
SELECT | ||
c1, | ||
SUM(c2) FILTER (WHERE c2 >= 20) AS sum_c2, | ||
AVG(c3) FILTER (WHERE c3 <= 70) AS avg_c3 | ||
FROM test_table GROUP BY c1 | ||
---- | ||
1 20 55 | ||
2 20 70 | ||
3 NULL NULL | ||
|
||
# query_group_by_distinct_with_filter | ||
query II rowsort | ||
SELECT c1, COUNT(DISTINCT c2) FILTER (WHERE c2 >= 20) AS distinct_c2_count FROM test_table GROUP BY c1 | ||
SELECT | ||
c1, | ||
COUNT(DISTINCT c2) FILTER (WHERE c2 >= 20) AS distinct_c2_count | ||
FROM test_table GROUP BY c1 | ||
---- | ||
1 1 | ||
2 1 | ||
3 0 | ||
|
||
# query_without_group_by_with_filter | ||
query I rowsort | ||
SELECT SUM(c2) FILTER (WHERE c2 >= 20) AS sum_c2 FROM test_table | ||
SELECT | ||
SUM(c2) FILTER (WHERE c2 >= 20) AS sum_c2 | ||
FROM test_table | ||
---- | ||
40 | ||
|
||
# count_without_group_by_with_filter | ||
query I rowsort | ||
SELECT COUNT(c2) FILTER (WHERE c2 >= 20) AS count_c2 FROM test_table | ||
SELECT | ||
COUNT(c2) FILTER (WHERE c2 >= 20) AS count_c2 | ||
FROM test_table | ||
---- | ||
2 | ||
|
||
# query_with_and_without_filter | ||
query III rowsort | ||
SELECT c1, SUM(c2) FILTER (WHERE c2 >= 20) as result, SUM(c2) as result_no_filter FROM test_table GROUP BY c1; | ||
SELECT | ||
c1, | ||
SUM(c2) FILTER (WHERE c2 >= 20) as result, | ||
SUM(c2) as result_no_filter | ||
FROM test_table GROUP BY c1; | ||
---- | ||
1 20 30 | ||
2 20 30 | ||
3 NULL 10 | ||
|
||
# query_filter_on_different_column_than_aggregate | ||
query I rowsort | ||
select sum(c1) FILTER (WHERE c2 < 30) from test_table; | ||
select | ||
sum(c1) FILTER (WHERE c2 < 30) | ||
FROM test_table; | ||
---- | ||
9 | ||
|
||
# query_test_empty_filter | ||
query I rowsort | ||
SELECT SUM(c2) FILTER (WHERE c2 >= 20000000) AS sum_c2 FROM test_table; | ||
SELECT | ||
SUM(c2) FILTER (WHERE c2 >= 20000000) AS sum_c2 | ||
FROM test_table; | ||
---- | ||
NULL | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some additional coverage with filtering