Minor: Add tests for User Defined Aggregate functions #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
There was a problem hiding this comment.
Very nice, @alamb – can I help you by submitting my branch as a PR to this branch?
Comment on lines
189
to
192
| /// was update_batch called? | ||
| update_batch: AtomicBool, | ||
| /// was retract batch called? | ||
| retract_batch: AtomicBool, |
There was a problem hiding this comment.
Nice way to test expectations 👌🏻
viirya
reviewed
Jun 14, 2023
viirya
reviewed
Jun 14, 2023
viirya
approved these changes
Jun 14, 2023
Thanks for the offer @stuartcarnie ! I already incorporated the code from your branch into #6671 (which I will have up as a PR shortly) |
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is part of #6611
Rationale for this change
I am adding support for sliding windows in user defined aggregates and I need some way to test it.
The actual code change is relatively small but it takes non trivial effort to test, so I wanted to add the tests first so the actual code change is clearer.
What changes are included in this PR?
Add more tests to
user_defined_aggregates.rsfor a user defined aggregates.Are these changes tested?
it is only tests
Are there any user-facing changes?
No