Minor: Add test for date_trunc schema on scalars #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
viirya
reviewed
Jun 12, 2023
There was a problem hiding this comment.
I think it actually causes some test failures in datafusion/core/tests/sql/timestamp.rs but the tests are modified.
|
But it is still good to add some more tests for this, especially in |
|
I think this test needs a rowsort -- will add it |
viirya
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6653
Rationale for this change
I was surprised that the change in #6654 did not cause a test failure so I reviewed our coverage and found there wasn't coverage for the schema of the scalar version of
date_truncWhat changes are included in this PR?
Add a test
Are these changes tested?
yes
Are there any user-facing changes?