Add hash support for PhysicalExpr and PhysicalSortExpr #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # datafusion/core/src/physical_plan/windows/mod.rs # datafusion/physical-expr/src/equivalence.rs
# Conflicts: # datafusion/physical-expr/src/equivalence.rs
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # datafusion/physical-expr/src/equivalence.rs
alamb
reviewed
Jun 11, 2023
There was a problem hiding this comment.
Thank you @mustafasrepo -- this looks really neat. I think it would be best if we could remove the panic's (via unimplemented) if possible
| @@ -39,7 +40,7 @@ pub struct EquivalenceProperties<T = Column> { | |||
| schema: SchemaRef, | |||
| } | |||
|
|
|||
| impl<T: PartialEq + Clone> EquivalenceProperties<T> { | |||
| impl<T: Eq + Clone + Hash> EquivalenceProperties<T> { | |||
alamb
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
LGTM -- thank you @mustafasrepo. This is a nice change I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In the discussion @alamb suggested to implement
dyn_hashmethod so that we can add support for hashing to traits. In this PR by using his suggestions we added support for hashing toPhysicalExprandPhysicalSortExpr. This enables us to useHashSetinsideEquivalentClass. Hence logic is simplified a bit inEquivalentClassandEquivalencePropertiesimplementation.What changes are included in this PR?
Are these changes tested?
This is a refactor, existing tests should be sufficient.
Are there any user-facing changes?
We add
fn dyn_hash(&self, _state: &mut dyn Hasher);method to thePhysicalExprtrait.