Allow non-equijoin filters in join condition #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alamb do you mind to take a look? |
alamb
approved these changes
Jul 6, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Nice work @Dandandan -- the only other thing I would suggest is a negative case
Something like this with a LEFT join:
SELECT t1_id, t1_name, t2_name FROM t1 LEFT JOIN t2 ON t1_id = t2_id AND t2_name >= 'y' ORDER BY t1_idAnd expect that that will error with unsupported
|
|
||
| if filter.is_empty() { | ||
| join.build() | ||
| } else if join_type == JoinType::Inner { |
Contributor
There was a problem hiding this comment.
👍 this is the right behavior.
| if filter.is_empty() { | ||
| join.build() | ||
| } else if join_type == JoinType::Inner { | ||
| join.filter( |
Contributor
There was a problem hiding this comment.
this is a fancy way of creating an AND chain 👍
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
andygrove
added a commit
to andygrove/datafusion
that referenced
this pull request
Jan 31, 2025
…che#660) * Move temporal expressions to spark-expr crate * reduce public api * reduce public api * update imports in benchmarks * fmt * remove unused dep
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
…che#660) * Move temporal expressions to spark-expr crate * reduce public api * reduce public api * update imports in benchmarks * fmt * remove unused dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #659
Rationale for this change
In queries, some expressions can be added that can not be handled by a equi-join. Those should be supported by moving them to a filter instead.
This is only done for inner join for now, supporting this for other (left/right) joins will require a bit more work.
What changes are included in this PR?
Changes the planner to add the unsupported expressions to a filter instead of returning an error.
This almost makes TPC-H query 13 pass, except from some small unsupported / ignored syntax.
Are there any user-facing changes?
No, should just be a bit more flexible.