Minor: Update the testing section of contributor guide #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
May 15, 2023
viirya
reviewed
May 15, 2023
Comment on lines
+128
to
131
| ### Unit tests | ||
|
|
||
| #### Unit tests | ||
| Tests for code in an individual module are defined in the same source file with a `test` module, following Rust convention. | ||
|
|
mustafasrepo
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
@mustafasrepo and I had a good conversation on #6234 (#6234 (comment)) about the rationale for sqllogictests and I wanted to include a summary of that discussion in the docs
What changes are included in this PR?
Update the contribution guide to be clearer about tests and the why of DataFusion using sqllogictests
Are these changes tested?
N/A
Are there any user-facing changes?
Docs