Skip to content

Port tests in wildcard.rs to sqllogictest #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2023

Conversation

masanobbb
Copy link
Contributor

@masanobbb masanobbb commented May 5, 2023

Which issue does this PR close?

Closes #6216

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes, I tested it with $ cargo test -p datafusion --test sqllogictests -- wildcard and $ cargo test -p datafusion --test sql_integration

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 5, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you so much @masanobbb

@alamb
Copy link
Contributor

alamb commented May 5, 2023

Since I am trying to keep the number of open PRs down I took the liberty of merging up from main to this branch as there was a conflict.

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @masanobbb

@jackwener jackwener merged commit 39ad9e8 into apache:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port tests in wildcard.rs to sqllogictest
3 participants