fix: reassign_predicate_columns w/ in-list expr

[crepererum]

Which issue does this PR close?

Related to upstream ticket https://github.com/influxdata/influxdb_iox/issues/7644

Rationale for this change

We need to also re-assign the schema stored within InListExpr at the same time when we replace the children.

This bug affects both the public API reassign_predicate_columns as well as potential internal use of it.

What changes are included in this PR?

Bugfix.

Are these changes tested?

New test.

Are there any user-facing changes?

-

[mingmwang]

LGTM

[mingmwang]

It is unrelated to this PR, but I think the original implementation of the reassign_predicate_columns() is strange, it should not leverage the transform() process to do the replacement if the schema is changed, because thetransform() process assumes the schema of the expr will not change.

[mingmwang]

There are some other physical Exprs which might be schema aware.

[mingmwang]

I think we should remove the input schema from those phyiscal Exprs, and move the type check in the physical expression planner.

[mingmwang]

My bad, looks like the input_schema: Schema in InListExpr was added by me in this PR
[Part1] Partition and Sort Enforcement, PhysicalExpr enhancement (#3969)

I will file a FOLLOWUP ticket to remove the input_schema in this and other physical exprs and move the validation logic to the physical expression planner. So that you do not need a specific handling on InListExpr to re-assign a schema.

[alamb]

Thank you @crepererum and @mingmwang