Skip to content

Conversation

@edrevo
Copy link
Contributor

@edrevo edrevo commented Jun 18, 2021

Which issue does this PR close?

Closes #588.

What changes are included in this PR?

  • Standalone feature in client lib
  • Removed --local param in executor

Are there any user-facing changes?

Yes, the executor no longer has a --local mode.

@edrevo
Copy link
Contributor Author

edrevo commented Jun 18, 2021

cc @andygrove

@codecov-commenter
Copy link

Codecov Report

Merging #589 (697dd15) into master (51e5445) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   76.02%   76.08%   +0.06%     
==========================================
  Files         156      158       +2     
  Lines       27063    27115      +52     
==========================================
+ Hits        20575    20631      +56     
+ Misses       6488     6484       -4     
Impacted Files Coverage Δ
ballista/rust/client/src/columnar_batch.rs 0.00% <ø> (ø)
ballista/rust/client/src/context.rs 0.00% <0.00%> (ø)
ballista/rust/executor/src/execution_loop.rs 0.00% <ø> (ø)
ballista/rust/executor/src/main.rs 0.00% <0.00%> (ø)
ballista/rust/executor/src/standalone.rs 0.00% <0.00%> (ø)
ballista/rust/scheduler/src/lib.rs 20.81% <ø> (ø)
ballista/rust/scheduler/src/standalone.rs 0.00% <0.00%> (ø)
benchmarks/src/bin/tpch.rs 30.98% <0.00%> (+0.14%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5445...697dd15. Read the comment docs.


# Base image extends debian:buster-slim
FROM rust:1.51.0-buster AS builder
FROM rust:1.52.1-buster AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.53 is out now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have 2 more PRs open. i'll change it in one of the other ones, if that's ok

@edrevo
Copy link
Contributor Author

edrevo commented Jun 21, 2021

Build failure seems like a Cargo issue. I've opened rust-lang/cargo#9608. Let's see if they confirm it is a bug or not.

@edrevo
Copy link
Contributor Author

edrevo commented Jun 22, 2021

@andygrove, this one should be ready for merge

@andygrove andygrove merged commit a461e9c into apache:master Jun 22, 2021
@edrevo edrevo deleted the true-standalone branch June 22, 2021 13:42
@houqp houqp added api change Changes the API exposed to users of the crate ballista labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ballista] Create "self-contained" mode in client library

5 participants