-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Move ballista standalone mode to client #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @andygrove |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 76.02% 76.08% +0.06%
==========================================
Files 156 158 +2
Lines 27063 27115 +52
==========================================
+ Hits 20575 20631 +56
+ Misses 6488 6484 -4
Continue to review full report at Codecov.
|
|
|
||
| # Base image extends debian:buster-slim | ||
| FROM rust:1.51.0-buster AS builder | ||
| FROM rust:1.52.1-buster AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.53 is out now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have 2 more PRs open. i'll change it in one of the other ones, if that's ok
|
Build failure seems like a Cargo issue. I've opened rust-lang/cargo#9608. Let's see if they confirm it is a bug or not. |
|
@andygrove, this one should be ready for merge |
Which issue does this PR close?
Closes #588.
What changes are included in this PR?
Are there any user-facing changes?
Yes, the executor no longer has a --local mode.