chore: deduplicate workspace fields in Cargo.toml #5519
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
core
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
Great job! Thanks @waynexia |
There was a problem hiding this comment.
Thank you @waynexia ! We also use the workspace feature in IOx https://github.com/influxdata/influxdb_iox/blob/9d00fec091f18639aba9ca8a7df7939d0ccc13ca/Cargo.toml#L118-L124 and it works great!
cc @andygrove I don't think this will change the publish flow when creating a new release
|
Benchmark runs are scheduled for baseline = f4f4d70 and contender = 8b5c1c7. 8b5c1c7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
It hurts when I want to test some local change on arrow/parquet/datafusion. I have to change all those dependencies to the local path. So I try to simplify our Cargo.toml using the new cargo feature workspace deduplicate which is stabilized in 1.64.
What changes are included in this PR?
Two major parts in Cargo.toml files are changes:
This should also reduce the work when bumping and releasing new versions. For the dependencies, I currently only include those arrow/parquet stuff in workspace dependencies. I can add others as well if need.
Are these changes tested?
Are there any user-facing changes?
The
rust-versionfield is changed from1.62to1.64.But I think it's fine to bump our MSRV.
1.62is too old to compile datafusion. I used to encounter an error that says "the featureerror_in_coredoes not exist" (it comes from one of our dependencies). However the feature PR is merged in rust-lang/rust#99917 on Aug 24, 2022 (while1.62is released in June, 2022)