Fix Decimal and Floating type coerce rule #4038
Conversation
github-actions
bot
added
core
| (Decimal128(_, _), Float32 | Float64) => { | ||
| Some(Float64) | ||
| } | ||
| (Float32 | Float64, Decimal128(_, _)) => { | ||
| Some(Float64) | ||
| } |
There was a problem hiding this comment.
Follow Spark's decimal type coercision rule.
There was a problem hiding this comment.
I think we need to add the same in comparison_binary_numeric_coercion and that helps towards q6
There was a problem hiding this comment.
I think we need to add the same in
comparison_binary_numeric_coercionand that helps towards q6
the rule between arithmetic op and logical op may be different.
viirya
force-pushed
the
fix_decimal_float_coerce
branch
3 times, most recently
from
9cb6e90
to
582cc14
Compare
viirya
force-pushed
the
fix_decimal_float_coerce
branch
from
582cc14
to
af10480
Compare
|
Thanks @viirya |
|
Benchmark runs are scheduled for baseline = a1c1cd2 and contender = 5cf090a. 5cf090a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
Thanks @andygrove @Dandandan |
Which issue does this PR close?
Closes #4035.
Rationale for this change
Currently coerce rule coerces floating types to decimal type. It doesn't look correct.
What changes are included in this PR?
Are there any user-facing changes?