Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the configurations of ConfigOptions in an ordered way so that we can directly compare the equality of two ConfigOptions by their debug strings #3953

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

yahoNanJing
Copy link
Contributor

Which issue does this PR close?

Closes #3952.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

…e can directly compare the equality of two ConfigOptions by their debug strings
@github-actions github-actions bot added the core Core DataFusion crate label Oct 25, 2022
@yahoNanJing
Copy link
Contributor Author

In Ballista, there're several places to check the equality of two ExecutionPlans by their Debug strings in UT.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend a test for this somehow, but I don't feel super strongly

f.debug_struct("ConfigOptions")
.field(
"options",
&format!("{:?}", BTreeMap::from_iter(self.options.iter())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yahoNanJing yahoNanJing merged commit 97ff345 into apache:master Oct 26, 2022
@ursabot
Copy link

ursabot commented Oct 26, 2022

Benchmark runs are scheduled for baseline = 10e64dc and contender = 97ff345. 97ff345 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
…e can directly compare the equality of two ConfigOptions by their debug strings (apache#3953)

Co-authored-by: yangzhong <yangzhong@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
5 participants