Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some uneeded code in CommonSubexprEliminate #3730

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 5, 2022

Draft as it builds on #3726 from @alex-natzka

Which issue does this PR close?

re #3635

Rationale for this change

The type of expressions should be determined by the schema of the input, not the schema of the node itself

What changes are included in this PR?

Remove uneeded (and incorrect) fallback

Are there any user-facing changes?

no

cc @waynexia

@alamb alamb marked this pull request as draft October 5, 2022 21:57
@github-actions github-actions bot added the optimizer Optimizer rules label Oct 5, 2022
@waynexia
Copy link
Member

waynexia commented Oct 8, 2022

Related patch: #1925

Looks like the removed code is unreachable after that.

@alamb alamb marked this pull request as ready for review October 11, 2022 12:19
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pulled in latest from master and ran tests.

@andygrove andygrove merged commit 24ede6a into apache:master Oct 11, 2022
@ursabot
Copy link

ursabot commented Oct 11, 2022

Benchmark runs are scheduled for baseline = 053dc5a and contender = 24ede6a. 24ede6a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/cleanup_subexpr branch October 12, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants