Skip to content

Conversation

@vchag
Copy link
Contributor

@vchag vchag commented Mar 16, 2022

Which issue does this PR close?

Closes #. #1813

Rationale for this change

To make sure the examples in https://arrow.apache.org/datafusion/user-guide/example-usage.html always work irrespective of API updates.

What changes are included in this PR?

  • Including a doc test for files in arrow-datafusion/docs/source/user-guide/example-usage.md

Are there any user-facing changes?

No

Are there any breaking changes?

No

Change-Id: I022ab0921f7743d990c3a721ba17c14087f73b42
@vchag vchag changed the title Automatically test doc examples in user guide Automatically test examples in user guide Mar 16, 2022
Copy link
Member

@yjshen yjshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test src/lib.rs - user_guid_example_tests (line 293) ... ok
test src/lib.rs - user_guid_example_tests (line 273) ... ok

LGTM, thanks @vchag!

@yjshen yjshen merged commit 9d87736 into apache:master Mar 16, 2022
@houqp
Copy link
Member

houqp commented Mar 17, 2022

nice automation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants