Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Feb 16, 2022

Which issue does this PR close?

Rationale for this change

i guess it's hard to split planners themselves, but at least for expr and physical-expr it's easier to put into different crates

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title physical sort crate create datafusion-physical-expr module Feb 16, 2022
@jimexist
Copy link
Member Author

note this shall be merged after full release of:

@alamb
Copy link
Contributor

alamb commented Feb 16, 2022

note this shall be merged after full release of:

If we need to make another RC of DataFusion, I plan to make a branch and cherry-pick whatever is needed back there (rather than picking up all the changes from master).

In other words I think it is fine to merge this PR now

@alamb
Copy link
Contributor

alamb commented Feb 16, 2022

(thanks for keeping this project going @jimexist )

@jimexist jimexist merged commit 584bb75 into master Feb 17, 2022
@jimexist jimexist deleted the physical-expr branch February 17, 2022 05:25
@jimexist jimexist changed the title create datafusion-physical-expr module [split/14] create datafusion-physical-expr module Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split datafusion-physical-expr module

2 participants