Return Error when parquet reader fails rather than no data with println!
#1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 15, 2022
| "+-----+----+----+", | ||
| ]; | ||
| assert_batches_sorted_eq!(expected, &read); | ||
| assert_contains!(read.unwrap_err().to_string(), |
There was a problem hiding this comment.
This test should have always failed -- see #1622 (comment)
andygrove
approved these changes
Feb 15, 2022
xudong963
approved these changes
Feb 16, 2022
Dandandan
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes: #1767 (cc @andygrove )
I believe this also fixes #1651 (cc @thinkharderdev )
Rationale for this change
Errors are getting ignored during processing. See #1767 for details
What changes are included in this PR?
ParquetExecstreamAre there any user-facing changes?
Errors are reported when there are real errors